Fix "name 'visibility' is not defined" error on Bazel 5 #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesses-canva
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins,
thii and
mattrobmattrob
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
keith
approved these changes
Sep 21, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swiftformat
Oct 19, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [build_bazel_rules_swift](https://togithub.com/bazelbuild/rules_swift) | http_archive | minor | `1.12.0` -> `1.13.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_swift (build_bazel_rules_swift)</summary> ### [`v1.13.0`](https://togithub.com/bazelbuild/rules_swift/releases/tag/1.13.0) [Compare Source](https://togithub.com/bazelbuild/rules_swift/compare/1.12.0...1.13.0) ##### What's Changed - Fixed "name 'visibility' is not defined" error on Bazel 5 by [@​jesses-canva](https://togithub.com/jesses-canva) in [https://github.com/bazelbuild/rules_swift/pull/1117](https://togithub.com/bazelbuild/rules_swift/pull/1117) - Limited `--cxxopt='-std=c++14'` to Linux builds by [@​thii](https://togithub.com/thii) in [https://github.com/bazelbuild/rules_swift/pull/1122](https://togithub.com/bazelbuild/rules_swift/pull/1122) - Add SwiftGRPCInfo provider by [@​AttilaTheFun](https://togithub.com/AttilaTheFun) in [https://github.com/bazelbuild/rules_swift/pull/1121](https://togithub.com/bazelbuild/rules_swift/pull/1121) This release is compatible with 5.x LTS, 6.x LTS, and bazel 7.x rolling releases ##### MODULE.bazel Snippet ```bzl bazel_dep(name = "rules_swift", version = "1.13.0", repo_name = "build_bazel_rules_swift") ``` ##### Workspace Snippet ```bzl load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "build_bazel_rules_swift", sha256 = "28a66ff5d97500f0304f4e8945d936fe0584e0d5b7a6f83258298007a93190ba", url = "https://github.com/bazelbuild/rules_swift/releases/download/1.13.0/rules_swift.1.13.0.tar.gz", ) load( "@​build_bazel_rules_swift//swift:repositories.bzl", "swift_rules_dependencies", ) swift_rules_dependencies() load( "@​build_bazel_rules_swift//swift:extras.bzl", "swift_rules_extra_dependencies", ) swift_rules_extra_dependencies() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
referenced
this pull request
in bazel-contrib/rules_bazel_integration_test
Oct 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [build_bazel_rules_swift](https://togithub.com/bazelbuild/rules_swift) | http_archive | minor | `1.12.0` -> `1.13.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_swift (build_bazel_rules_swift)</summary> ### [`v1.13.0`](https://togithub.com/bazelbuild/rules_swift/releases/tag/1.13.0) [Compare Source](https://togithub.com/bazelbuild/rules_swift/compare/1.12.0...1.13.0) #### What's Changed - Fixed "name 'visibility' is not defined" error on Bazel 5 by [@​jesses-canva](https://togithub.com/jesses-canva) in [https://github.com/bazelbuild/rules_swift/pull/1117](https://togithub.com/bazelbuild/rules_swift/pull/1117) - Limited `--cxxopt='-std=c++14'` to Linux builds by [@​thii](https://togithub.com/thii) in [https://github.com/bazelbuild/rules_swift/pull/1122](https://togithub.com/bazelbuild/rules_swift/pull/1122) - Add SwiftGRPCInfo provider by [@​AttilaTheFun](https://togithub.com/AttilaTheFun) in [https://github.com/bazelbuild/rules_swift/pull/1121](https://togithub.com/bazelbuild/rules_swift/pull/1121) This release is compatible with 5.x LTS, 6.x LTS, and bazel 7.x rolling releases ##### MODULE.bazel Snippet ```bzl bazel_dep(name = "rules_swift", version = "1.13.0", repo_name = "build_bazel_rules_swift") ``` ##### Workspace Snippet ```bzl load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "build_bazel_rules_swift", sha256 = "28a66ff5d97500f0304f4e8945d936fe0584e0d5b7a6f83258298007a93190ba", url = "https://github.com/bazelbuild/rules_swift/releases/download/1.13.0/rules_swift.1.13.0.tar.gz", ) load( "@​build_bazel_rules_swift//swift:repositories.bzl", "swift_rules_dependencies", ) swift_rules_dependencies() load( "@​build_bazel_rules_swift//swift:extras.bzl", "swift_rules_extra_dependencies", ) swift_rules_extra_dependencies() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Oct 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [build_bazel_rules_swift](https://togithub.com/bazelbuild/rules_swift) | http_archive | minor | `1.12.0` -> `1.13.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_swift (build_bazel_rules_swift)</summary> ### [`v1.13.0`](https://togithub.com/bazelbuild/rules_swift/releases/tag/1.13.0) [Compare Source](https://togithub.com/bazelbuild/rules_swift/compare/1.12.0...1.13.0) ##### What's Changed - Fixed "name 'visibility' is not defined" error on Bazel 5 by [@​jesses-canva](https://togithub.com/jesses-canva) in [https://github.com/bazelbuild/rules_swift/pull/1117](https://togithub.com/bazelbuild/rules_swift/pull/1117) - Limited `--cxxopt='-std=c++14'` to Linux builds by [@​thii](https://togithub.com/thii) in [https://github.com/bazelbuild/rules_swift/pull/1122](https://togithub.com/bazelbuild/rules_swift/pull/1122) - Add SwiftGRPCInfo provider by [@​AttilaTheFun](https://togithub.com/AttilaTheFun) in [https://github.com/bazelbuild/rules_swift/pull/1121](https://togithub.com/bazelbuild/rules_swift/pull/1121) This release is compatible with 5.x LTS, 6.x LTS, and bazel 7.x rolling releases ##### MODULE.bazel Snippet ```bzl bazel_dep(name = "rules_swift", version = "1.13.0", repo_name = "build_bazel_rules_swift") ``` ##### Workspace Snippet ```bzl load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "build_bazel_rules_swift", sha256 = "28a66ff5d97500f0304f4e8945d936fe0584e0d5b7a6f83258298007a93190ba", url = "https://github.com/bazelbuild/rules_swift/releases/download/1.13.0/rules_swift.1.13.0.tar.gz", ) load( "@​build_bazel_rules_swift//swift:repositories.bzl", "swift_rules_dependencies", ) swift_rules_dependencies() load( "@​build_bazel_rules_swift//swift:extras.bzl", "swift_rules_extra_dependencies", ) swift_rules_extra_dependencies() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error